dongjoon-hyun commented on a change in pull request #25408: [SPARK-28687][SQL]
Support `epoch`, `isoyear`, `milliseconds` and `microseconds` at `extract()`
URL: https://github.com/apache/spark/pull/25408#discussion_r313473255
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
##########
@@ -1426,6 +1428,12 @@ class AstBuilder(conf: SQLConf) extends
SqlBaseBaseVisitor[AnyRef] with Logging
Minute(expression(ctx.source))
case "SECOND" =>
Second(expression(ctx.source))
+ case "MILLISECONDS" | "MSEC" =>
Review comment:
Let me be clear. I didn't check PostgreSQL full variants, but, at least,
`MS` and `MSECS` are missing here.
cc @maropu . Could you help @MaxGekk to complete this feature?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
