srowen commented on issue #25423: [SPARK-28701][test-java11][k8s] adding java11 support for pull request builds URL: https://github.com/apache/spark/pull/25423#issuecomment-520621370 @shaneknapp Hm, the K8S failures are symptomatic of building with Java 11, but testing with 8: ``` NoSuchMethodError: java.nio.ByteBuffer.flip()Ljava/nio/ByteBuffer ``` The signature it's looking for is what changed in Java 9+. Ideally we want to build with 8 and test with 11. (For the moment, building and testing with 11 would help a little, but not in the long term.) I see that both the new and existing Java 11 PR builder just sets `JAVA_HOME` but doesn't set `java.version` in the build. I believe that means it ends up finding Java 8 to test (well, it probably runs Java 11 with a Java 8 bootclasspath). You could check this hypothesis by adding `-Djava.version=11` to the `mvn` test command but, hm, this is invoking `dev-run-integration-tests.sh` which doesn't look like it's open to adding new arguments. So, hm, a few things that are probably at work: - This change probably has to add `-Djava.version=11` if Java 11 is selected, but also, set `JAVA_HOME` to 11 only for the test phase - I think the other Java 11 build jobs need a similar treatment, or really, they'd just use the support here when ready, right -- that's the idea? rather than do something similar in the build scripts - Somehow we have to plumb through a way to set `-Djava.version=11` to the K8S integration tests support
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
