srowen commented on issue #25423: [SPARK-28701][test-java11][k8s] adding java11 support for pull request builds URL: https://github.com/apache/spark/pull/25423#issuecomment-521733832 Many things going on here. So, we build with Java 8 and test with 11. This should be true for Maven and SBT. I think `dev/run-tests.py` has to set `JAVA_HOME` only in, say, `run_scala_tests` and also set `-Djava.version=11` for both. But it should not affect the rest of the build/test process. I am a little confused about what is meant to be in the Jenkins' script vs what's in this test driver script. Jenkins config _also_ seems to compile Spark with Maven (IIRC; I can't see it right now). Is that redundant? But, that build part should not use Java 11, hence agree that it shouldn't be in any compile-related script in Jenkins config. And then I'm still confused about why SBT doesn't like it. We shouldn't be asking it to compile anything if it's only applied during the test phase, and its error only concerns applying `scalac -target=jvm-11` But we should never need that. As this appears to be written, though, it sets `SBT_OPTS` for SBT compilation too, and that won't work. Is that the issue? (The K8S changes look OK)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
