younggyuchun commented on a change in pull request #25458: [SPARK-27931][SQL] Accept 'on' and 'off' as input and trim input for the boolean data type. URL: https://github.com/apache/spark/pull/25458#discussion_r314174879
########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/StringUtils.scala ########## @@ -65,12 +65,15 @@ object StringUtils extends Logging { "(?s)" + out.result() // (?s) enables dotall mode, causing "." to match new lines } - private[this] val trueStrings = Set("t", "true", "y", "yes", "1").map(UTF8String.fromString) - private[this] val falseStrings = Set("f", "false", "n", "no", "0").map(UTF8String.fromString) + private[this] val trueStrings = + Set("t", "true", "y", "yes", "1", "on").map(UTF8String.fromString) + + private[this] val falseStrings = + Set("f", "false", "n", "no", "0", "off").map(UTF8String.fromString) Review comment: Yes I guess so. Do you know other common string representattion used in other databases? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org