younggyuchun commented on a change in pull request #25458: [SPARK-27931][SQL]
Accept 'on' and 'off' as input and trim input for the boolean data type.
URL: https://github.com/apache/spark/pull/25458#discussion_r314716565
##########
File path: sql/core/src/test/resources/sql-tests/inputs/pgSQL/boolean.sql
##########
@@ -23,7 +23,7 @@ SELECT false AS `false`;
SELECT boolean('t') AS true;
-- [SPARK-27931] Trim the string when cast string type to boolean type
-SELECT boolean(' f ') AS `false`;
+SELECT boolean(' f ') AS `true`;
Review comment:
@wangyum I think it should be 'true'. Is it correct?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
