MaxGekk commented on a change in pull request #25410: [SPARK-28690][SQL] Add 
`date_part` function for timestamps/dates
URL: https://github.com/apache/spark/pull/25410#discussion_r314596136
 
 

 ##########
 File path: sql/core/src/test/resources/sql-tests/inputs/pgSQL/timestamp.sql
 ##########
 @@ -187,22 +187,21 @@ SELECT '' AS date_trunc_week, date_trunc( 'week', 
timestamp '2004-02-29 15:44:17
 --   WHERE d1 BETWEEN timestamp '1902-01-01'
 --    AND timestamp '2038-01-01';
 
--- [SPARK-28420] Date/Time Functions: date_part
--- SELECT '' AS "54", d1 as "timestamp",
---    date_part( 'year', d1) AS year, date_part( 'month', d1) AS month,
---    date_part( 'day', d1) AS day, date_part( 'hour', d1) AS hour,
---    date_part( 'minute', d1) AS minute, date_part( 'second', d1) AS second
---    FROM TIMESTAMP_TBL WHERE d1 BETWEEN '1902-01-01' AND '2038-01-01';
-
--- SELECT '' AS "54", d1 as "timestamp",
---    date_part( 'quarter', d1) AS quarter, date_part( 'msec', d1) AS msec,
---    date_part( 'usec', d1) AS usec
---    FROM TIMESTAMP_TBL WHERE d1 BETWEEN '1902-01-01' AND '2038-01-01';
-
--- SELECT '' AS "54", d1 as "timestamp",
---    date_part( 'isoyear', d1) AS isoyear, date_part( 'week', d1) AS week,
---    date_part( 'dow', d1) AS dow
---    FROM TIMESTAMP_TBL WHERE d1 BETWEEN '1902-01-01' AND '2038-01-01';
+SELECT '' AS `54`, d1 as `timestamp`,
 
 Review comment:
   @dongjoon-hyun When I removed them, I got the error:
   ```
   -- !query 13
   SELECT '' AS `54`, d1 as `timestamp`,
       date_part( 'year', d1) AS year, date_part( 'month', d1) AS month,
       date_part( 'day', d1) AS day, date_part( 'hour', d1) AS hour,
       date_part( 'minute', d1) AS minute, date_part( 'second', d1) AS second
       FROM TIMESTAMP_TBL WHERE d1 BETWEEN '1902-01-01' AND '2038-01-01'
   -- !query 13 schema
   struct<>
   -- !query 13 output
   org.apache.spark.sql.catalyst.parser.ParseException
   
   no viable alternative at input 'year'(line 2, pos 30)
   
   == SQL ==
   SELECT '' AS `54`, d1 as `timestamp`,
       date_part( 'year', d1) AS year, date_part( 'month', d1) AS month,
   ------------------------------^^^
       date_part( 'day', d1) AS day, date_part( 'hour', d1) AS hour,
       date_part( 'minute', d1) AS minute, date_part( 'second', d1) AS second
       FROM TIMESTAMP_TBL WHERE d1 BETWEEN '1902-01-01' AND '2038-01-01'
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to