Github user CodingCat commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4129#discussion_r23299681
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/cluster/SparkDeploySchedulerBackend.scala
 ---
    @@ -78,7 +78,11 @@ private[spark] class SparkDeploySchedulerBackend(
         val appUIAddress = sc.ui.map(_.appUIAddress).getOrElse("")
         val appDesc = new ApplicationDescription(sc.appName, maxCores, 
sc.executorMemory, command,
           appUIAddress, sc.eventLogDir)
    -
    +    appDesc.coreNumPerTask = conf.getInt("spark.task.cpus", 1)
    --- End diff --
    
    I chose var with the concern that, if I use val, that means I need to add 
it as the constructor parameter...just not sure if I can pass the binary 
compatibility checking 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to