Github user CodingCat commented on a diff in the pull request:
https://github.com/apache/spark/pull/4129#discussion_r23299862
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala
---
@@ -87,7 +89,12 @@ private[spark] class CoarseMesosSchedulerBackend(
override def start() {
super.start()
-
+
+ if (coreNumPerTask < 1) {
+ throw new IllegalArgumentException(
+ s"spark.task.cpus is set to an invalid value $coreNumPerTask")
+ }
--- End diff --
we can do that...but is it a good practice to throw exceptions in the
constructor?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
