Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/4120#discussion_r23331676
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/EventLoggingListener.scala ---
@@ -86,8 +86,14 @@ private[spark] class EventLoggingListener(
* Creates the log file in the configured log directory.
*/
def start() {
- if (!fileSystem.isDirectory(new Path(logBaseDir))) {
- throw new IllegalArgumentException(s"Log directory $logBaseDir does
not exist.")
+ try{
--- End diff --
Here's our code style guide:
https://cwiki.apache.org/confluence/display/SPARK/Spark+Code+Style+Guide
The Spark style would format the code like this:
```scala
try {
if (!filesystem.getFileStatus(newPath(logBaseDir)).isDir()) {
throw new IllegalArgumentException(s"Log directory $logBaseDir is not a
directory.")
}
} catch {
case ioe: FileNotFoundException => fileSystem.mkdirs(newPath(logBaseDir)))
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
