Github user ganonp commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4120#discussion_r23332402
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/EventLoggingListener.scala ---
    @@ -86,8 +86,14 @@ private[spark] class EventLoggingListener(
        * Creates the log file in the configured log directory.
        */
       def start() {
    -    if (!fileSystem.isDirectory(new Path(logBaseDir))) {
    -      throw new IllegalArgumentException(s"Log directory $logBaseDir does 
not exist.")
    +    try{
    --- End diff --
    
    Ok, got it, sorry and thanks for correcting it. I read the style guid last 
time I contributed, but obviously forgot and didn't look at it again this time. 
However, I did use the scalastyle script in the dev folder this time and it 
said everything was good, so I probably need to figure out what I did wrong 
with that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to