rdblue commented on a change in pull request #25348: [SPARK-28554][SQL] Adds a
v1 fallback writer implementation for v2 data source codepaths
URL: https://github.com/apache/spark/pull/25348#discussion_r315453138
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/WriteToDataSourceV2Exec.scala
##########
@@ -238,12 +246,11 @@ case class AtomicReplaceTableAsSelectExec(
*/
case class AppendDataExec(
table: SupportsWrite,
- writeOptions: CaseInsensitiveStringMap,
- query: SparkPlan) extends V2TableWriteExec with BatchWriteHelper {
+ writeBuilder: WriteBuilder,
+ query: SparkPlan) extends V2TableWriteExec {
Review comment:
Since thinking about the impact to `simpleString`, I realized that this is
also going to delegate to the write builder for other methods as well,
including `equals` and `hashCode`. Since we can't rely on the behavior of the
write builder's `equals` and `hashCode` methods, I don't think it the builder
should be used as an argument to the plan case classes.
I think that also makes sense: case classes are algebraic types, so we
shouldn't include objects in their definitions that don't behave like algebraic
types.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
