rdblue commented on a change in pull request #25348: [SPARK-28554][SQL] Adds a
v1 fallback writer implementation for v2 data source codepaths
URL: https://github.com/apache/spark/pull/25348#discussion_r315455502
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/sources/v2/TestInMemoryTableCatalog.scala
##########
@@ -234,7 +234,8 @@ class InMemoryTable(
private class Overwrite(filters: Array[Filter]) extends TestBatchWrite {
override def commit(messages: Array[WriterCommitMessage]): Unit =
dataMap.synchronized {
- dataMap --= deletesKeys(filters)
+ val deleteKeys = InMemoryTable.filtersToKeys(dataMap.keys,
partFieldNames, filters)
+ dataMap --= deleteKeys
Review comment:
Is the refactoring in this file required? I like the refactor, but I don't
think it is making a functional change so we should probably not include it in
this commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
