srowen commented on a change in pull request #25439: [SPARK-28709][DSTREAMS] -
Fix StreamingContext leak through Streaming…
URL: https://github.com/apache/spark/pull/25439#discussion_r315706444
##########
File path:
streaming/src/main/scala/org/apache/spark/streaming/ui/StreamingTab.scala
##########
@@ -26,37 +25,24 @@ import org.apache.spark.ui.{SparkUI, SparkUITab}
* Spark Web UI tab that shows statistics of a streaming job.
* This assumes the given SparkContext has enabled its SparkUI.
*/
-private[spark] class StreamingTab(val ssc: StreamingContext)
- extends SparkUITab(StreamingTab.getSparkUI(ssc), "streaming") with Logging {
-
- import StreamingTab._
+private[spark] class StreamingTab(val ssc: StreamingContext, sparkUI: SparkUI)
Review comment:
Is it necessary to plumb through the reference to `SparkUI` vs getting it
how it's done now? If it's just for tidiness, I think that's probably OK too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
