srowen commented on a change in pull request #25439: [SPARK-28709][DSTREAMS] -
Fix StreamingContext leak through Streaming…
URL: https://github.com/apache/spark/pull/25439#discussion_r315706056
##########
File path:
streaming/src/main/scala/org/apache/spark/streaming/StreamingContext.scala
##########
@@ -575,6 +577,8 @@ class StreamingContext private[streaming] (
try {
validate()
+ registerProgressListener()
Review comment:
Yes I tend to agree. The behavior change is registering listeners when when
the UI is disabled, but that seems like possibly a fix (we'd have to look
deeper to figure out whether something _else_ registers it in this case, like
`StreamingSource`). This seems like a better place to manage it, certainly
unregistering, and if it's unregistered here it should be registered here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
