cloud-fan commented on a change in pull request #25461: [SPARK-28741][SQL]Throw
exceptions when casting to integers causes overflow
URL: https://github.com/apache/spark/pull/25461#discussion_r316213585
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
##########
@@ -1182,6 +1233,64 @@ case class Cast(child: Expression, dataType: DataType,
timeZoneId: Option[String
(c, evPrim, evNull) => code"$evPrim = $c != 0;"
}
+ private[this] def castTimestampToIntegerCode(
+ ctx: CodegenContext,
+ integralType: String): CastFunction = {
+ if (failOnIntegerOverflow) {
+ val longValue = ctx.freshName("longValue")
+ (c, evPrim, evNull) =>
+ code"""
+ long $longValue = ${timestampToLongCode(c)};
+ if ($longValue == ($integralType) $longValue) {
+ $evPrim = ($integralType) $longValue;
+ } else {
+ throw new ArithmeticException("Casting $c to $integralType causes
overflow");
+ }
+ """
+ } else {
+ (c, evPrim, evNull) => code"$evPrim = ($integralType)
${timestampToLongCode(c)};"
+ }
+ }
+
+ private[this] def lowerAndUpperBound(integralType: String): (Double, Double)
= {
Review comment:
let's move it closer to where it's called.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
