cloud-fan commented on a change in pull request #25461: [SPARK-28741][SQL]Throw
exceptions when casting to integers causes overflow
URL: https://github.com/apache/spark/pull/25461#discussion_r316216553
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/numerics.scala
##########
@@ -107,4 +109,85 @@ object LongExactNumeric extends LongIsIntegral with
Ordering.LongOrdering {
override def times(x: Long, y: Long): Long = Math.multiplyExact(x, y)
override def negate(x: Long): Long = Math.negateExact(x)
+
+ override def toInt(x: Long): Int =
+ if (x == x.toInt) {
+ x.toInt
+ } else {
+ throw new ArithmeticException(s"Casting $x to int causes overflow.")
+ }
+}
+
+object FloatExactNumeric extends FloatIsFractional with Ordering.FloatOrdering
{
+ private def overflowException(x: Float, dataType: String) =
+ throw new ArithmeticException(s"Casting $x to $dataType causes overflow.")
+
+ private val intUpperBound = Int.MaxValue + 1L
+ private val intLowerBound = Int.MinValue - 1L
+ // We cannot compare `Long.MAX_VALUE` to a float without losing precision.
+ // In fact, the difference between `Math.nextUp(Long.MAX_VALUE.toFloat)` and
+ // `Long.MAX_VALUE.toFloat` is 1.09951163E12.
+ // To make it simple, we compare the input value with
`Long.MaxValue.toFloat` directly.
+ private val longUpperBound = Long.MaxValue.toFloat
+ // We cannot compare `Long.MIN_VALUE` to a float without losing precision.
+ // In fact, the difference between `Math.nextDown(Long.MIN_VALUE.toFloat)`
and
+ // `Long.MIN_VALUE.toFloat` is -1.09951163E12.
+ // To make it simple, we compare the input value with
`Long.MIN_VALUE.toFloat` directly.
Review comment:
we can probably merge the comments of `longUpperBound` and `longLowerBound`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
