rdblue commented on a change in pull request #25354: [SPARK-28612][SQL] Add
DataFrameWriterV2 API
URL: https://github.com/apache/spark/pull/25354#discussion_r316273986
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
##########
@@ -548,15 +562,22 @@ object OverwriteByExpression {
case class OverwritePartitionsDynamic(
table: NamedRelation,
query: LogicalPlan,
+ writeOptions: Map[String, String],
Review comment:
Yes, it is for style. Boolean parameters should be passed by name, like
`isByName = false`. Although you can pass positional parameters after a named
parameter, the expectation is usually that named parameters are not necessarily
in the correct position and can be omitted or reordered.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
