rdblue commented on a change in pull request #25354: [SPARK-28612][SQL] Add
DataFrameWriterV2 API
URL: https://github.com/apache/spark/pull/25354#discussion_r316443121
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/functions.scala
##########
@@ -3900,6 +3900,61 @@ object functions {
*/
def to_csv(e: Column): Column = to_csv(e, Map.empty[String, String].asJava)
+ /**
+ * A transform for timestamps and dates to partition data into years.
+ *
+ * @group partition_transforms
+ * @since 3.0.0
+ */
+ def years(e: Column): Column = withExpr { Years(e.expr) }
Review comment:
I think the names should match the SQL names, which are `years`, `months`,
etc.
I think I like "partitioning" the best, since it qualifies the function.
`partitioning.years`. Should I make this change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
