LuciferYang commented on a change in pull request #25309:
[SPARK-28577][YARN]Resource capability requested for each executor add
offHeapMemorySize
URL: https://github.com/apache/spark/pull/25309#discussion_r318458776
##########
File path: docs/configuration.md
##########
@@ -1357,9 +1357,8 @@ Apart from these, the following properties are also
available, and may be useful
<td>
If true, Spark will attempt to use off-heap memory for certain operations.
If off-heap memory
use is enabled, then <code>spark.memory.offHeap.size</code> must be
positive.
- <em>Note:</em> If off-heap memory is enabled, may need to raise the
non-heap memory size
- (e.g. increase <code>spark.driver.memoryOverhead</code> or
- <code>spark.executor.memoryOverhead</code>).
+ <em>Note:</em> If off-heap memory is enabled, may need to raise
+ <code>spark.driver.memoryOverhead</code> size.
Review comment:
I have the same question :)，broadcast in driver side may not use offheap,
`TorrentBroadcast.writeBlocks` method call `blockManager.putSingle` method use
`StorageLevel.MEMORY_AND_DISK` and call `blockManager.putBytes` method use
`StorageLevel.MEMORY_AND_DISK_SER`, both these 2 StorageLevel not use offheap
memory, maybe we should remove these 2 line.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
