LuciferYang commented on a change in pull request #25309:
[SPARK-28577][YARN]Resource capability requested for each executor add
offHeapMemorySize
URL: https://github.com/apache/spark/pull/25309#discussion_r319799420
##########
File path:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala
##########
@@ -149,7 +151,7 @@ private[yarn] class YarnAllocator(
// Resource capability requested for each executor
private[yarn] val resource: Resource = {
val resource = Resource.newInstance(
- executorMemory + memoryOverhead + pysparkWorkerMemory, executorCores)
+ executorMemory + executorOffHeapMemory + memoryOverhead +
pysparkWorkerMemory, executorCores)
Review comment:
@srowen `memoryOverhead` include `MEMORY_OFFHEAP_SIZE ` before this pr, and
`memoryOverhead` and `MEMORY_OFFHEAP_SIZE ` had to be modified at the same time
to ensure request enough resources from yarn if I want to increase
`MEMORY_OFFHEAP_SIZE `, this is not user friendly, and this has always been
confusing, why do we need to modify two memory-related parameters
simultaneously for one purpose? This pr let them be independent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
