cloud-fan commented on a change in pull request #20965: [SPARK-21870][SQL]
Split aggregation code into small functions
URL: https://github.com/apache/spark/pull/20965#discussion_r319949113
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
##########
@@ -174,8 +176,9 @@ case class HashAggregateExec(
}
}
- // The variables used as aggregation buffer. Only used for aggregation
without keys.
- private var bufVars: Seq[ExprCode] = _
+ // The variables are used as aggregation buffers and each aggregate function
has one more ExprCode
Review comment:
`one more` -> `one or more`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
