cloud-fan commented on a change in pull request #20965: [SPARK-21870][SQL]
Split aggregation code into small functions
URL: https://github.com/apache/spark/pull/20965#discussion_r319952695
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
##########
@@ -255,41 +261,153 @@ case class HashAggregateExec(
""".stripMargin
}
+ private def isValidParamLength(paramLength: Int): Boolean = {
+ // This config is only for testing
+ sqlContext.getConf("spark.sql.HashAggregateExec.isValidParamLength", null)
match {
+ case null | "" => CodeGenerator.isValidParamLength(paramLength)
+ case validLength => paramLength <= validLength.toInt
+ }
+ }
+
+ // Splits aggregate code into small functions because the most of JVM
implementations
+ // can not compile too long functions.
Review comment:
let's mention that it returns None if we are not able to split the code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
