imback82 commented on a change in pull request #25601: [SPARK-28856][SQL] Implement SHOW DATABASES for Data Source V2 Tables URL: https://github.com/apache/spark/pull/25601#discussion_r320552362
########## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/connector/InMemoryTableCatalog.scala ########## @@ -30,12 +30,9 @@ import org.apache.spark.sql.sources.v2.Table import org.apache.spark.sql.types.StructType import org.apache.spark.sql.util.CaseInsensitiveStringMap -class InMemoryTableCatalog extends TableCatalog with SupportsNamespaces { +class InMemoryTableCatalogBase extends TableCatalog { Review comment: I tried to have a catalog without `SupportsNamespace`. If you have a better name, please let me know. :) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org