imback82 commented on a change in pull request #25601: [SPARK-28856][SQL]
Implement SHOW DATABASES for Data Source V2 Tables
URL: https://github.com/apache/spark/pull/25601#discussion_r320848600
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
##########
@@ -560,6 +560,17 @@ object OverwritePartitionsDynamic {
}
}
+/**
+ * The logical plan of the SHOW NAMESPACES command that works for v2 catalogs.
+ */
+case class ShowNamespaces(
+ catalog: SupportsNamespaces,
+ namespace: Option[Seq[String]],
Review comment:
This is just `namespace` since catalog is already resolved in
`DataSourceResolution.scala`. The `namespace` in `ShowNamespacesStatement` is
catalog + namespace, but I followed the same convention as other statements -
i.e., `CreateTableStatement` has `tableName` instead of `catalogAndTableName`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
