cloud-fan commented on a change in pull request #25679: [SPARK-28974][SQL]
centralize the Data Source V2 table capability checks
URL: https://github.com/apache/spark/pull/25679#discussion_r320764775
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Strategy.scala
##########
@@ -237,6 +237,9 @@ object DataSourceV2Strategy extends Strategy with
PredicateHelper {
OverwritePartitionsDynamicExec(r.table.asWritable, r.options,
planLater(query)) :: Nil
case DeleteFromTable(r: DataSourceV2Relation, condition) =>
+ if (SubqueryExpression.hasSubquery(condition)) {
Review comment:
also see
https://github.com/apache/spark/pull/25626/files#diff-fc4a83061d40a242e7f7b729cb8ee870R251
We think that the subquery check is for the current limitation, which should
not be treated as a capability check. It's better to put it near the
implementation, and should be updated together when we improve the
implementation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
