cloud-fan commented on a change in pull request #25679: [SPARK-28974][SQL]
centralize the Data Source V2 table capability checks
URL: https://github.com/apache/spark/pull/25679#discussion_r320767528
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/sources/v2/TableCapabilityCheckSuite.scala
##########
@@ -91,11 +144,10 @@ class V2WriteSupportCheckSuite extends AnalysisTest {
EqualTo(AttributeReference("x", LongType)(), Literal(5)))
val exc = intercept[AnalysisException]{
- V2WriteSupportCheck.apply(plan)
+ TableCapabilityCheck.apply(plan)
}
- assert(exc.getMessage.contains(
- "does not support overwrite expression (`x` = 5) in batch mode"))
+ assert(exc.getMessage.contains("does not support overwrite by filter in
batch mode"))
Review comment:
I updated the error message a little bit. The previous message is a little
misleading that only the specific expression is not supported.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
