mgaido91 commented on issue #25642: [SPARK-28916][SQL] Split subexpression elimination functions code URL: https://github.com/apache/spark/pull/25642#issuecomment-527908860 > btw, (this is a off-topic though) the HashAggregateExec code for common subexpr elimination has the same issue? That also expands all generated the code for CSE in a single method now; https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala#L287 @maropu I think the point there is that in case of wholestage codegen we are not able to split things at the moment, so I am not sure whether is is possible doing anything better there.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
