mgaido91 commented on issue #25642: [SPARK-28916][SQL] Split subexpression elimination functions code URL: https://github.com/apache/spark/pull/25642#issuecomment-527911315 > But I was curious whether or not it makes more sense to perform a tree-splitting instead of a fixed-level splitting. @rednaxelafx actually we are doing something similar to what you are suggesting. We already have a 2 or more levels splitting feature. The point is that the splitting point is given by the inner classes. We can say that now we assume that the number of function calls which fits in a single inner classes are a safe threshold for the number of function calls inside a specific function. This is not exactly what you are proposing, as it is not driven by the method size conf, but it is close. For more details please check `generateInnerClassesFunctionCalls` and SPARK-22226.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
