vanzin commented on a change in pull request #25620: [SPARK-25341][Core]
Support rolling back a shuffle map stage and re-generate the shuffle files
URL: https://github.com/apache/spark/pull/25620#discussion_r320919796
##########
File path:
core/src/main/scala/org/apache/spark/shuffle/sort/SortShuffleManager.scala
##########
@@ -79,9 +81,9 @@ private[spark] class SortShuffleManager(conf: SparkConf)
extends ShuffleManager
}
/**
- * A mapping from shuffle ids to the number of mappers producing output for
those shuffles.
+ * A mapping from shuffle ids to the task ids of mappers producing output
for those shuffles.
*/
- private[this] val numMapsForShuffle = new ConcurrentHashMap[Int, Int]()
+ private[this] val taskIdMapsForShuffle = new ConcurrentHashMap[Int,
ArrayBuffer[Long]]()
Review comment:
This doesn't seem too worrying at first (even 10MB per stage isn't that much
overhead if it's cleaned up eventually). But perhaps using `OpenHashSet` can
help with larger stages (vs. an `ArrayBuffer`), although it will use more
memory for smaller ones.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
