vanzin commented on a change in pull request #25620: [SPARK-25341][Core]
Support rolling back a shuffle map stage and re-generate the shuffle files
URL: https://github.com/apache/spark/pull/25620#discussion_r320913188
##########
File path: core/src/main/scala/org/apache/spark/MapOutputTracker.scala
##########
@@ -645,13 +649,18 @@ private[spark] class MapOutputTrackerMaster(
// Get blocks sizes by executor Id. Note that zero-sized blocks are excluded
in the result.
// This method is only called in local-mode.
- def getMapSizesByExecutorId(shuffleId: Int, startPartition: Int,
endPartition: Int)
- : Iterator[(BlockManagerId, Seq[(BlockId, Long)])] = {
+ def getMapSizesByExecutorId(
+ shuffleId: Int,
+ startPartition: Int,
+ endPartition: Int,
+ useOldFetchProtocol: Boolean)
+ : Iterator[(BlockManagerId, Seq[(BlockId, Long, Int)])] = {
Review comment:
nit: indent more or less. It should be at a different indent level than the
method body.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
