hddong commented on a change in pull request #25389: [SPARK-28657][CORE] Fix 
currentContext Instance failed sometimes
URL: https://github.com/apache/spark/pull/25389#discussion_r321040043
 
 

 ##########
 File path: core/src/test/scala/org/apache/spark/util/UtilsSuite.scala
 ##########
 @@ -924,6 +926,24 @@ class UtilsSuite extends SparkFunSuite with 
ResetSystemProperties with Logging {
     }
   }
 
+  test("test class ClassCastException") {
 
 Review comment:
   > This test does not seem to be testing Spark code? I don't understand.
   
   If no exception is thrown, it will run into line 938 `assert(false)` and 
this test will not pass. But it always go into `catch`, throw 
`ClassCastException `, so this test pass. Actually, i am not sure is it issue 
for others.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to