hddong commented on a change in pull request #25389: [SPARK-28657][CORE] Fix 
currentContext Instance failed sometimes
URL: https://github.com/apache/spark/pull/25389#discussion_r321550620
 
 

 ##########
 File path: core/src/test/scala/org/apache/spark/util/UtilsSuite.scala
 ##########
 @@ -915,6 +918,7 @@ class UtilsSuite extends SparkFunSuite with 
ResetSystemProperties with Logging {
   }
 
   test("Set Spark CallerContext") {
+    SparkHadoopUtil.get.conf.setBoolean("hadoop.caller.context.enabled", true);
 
 Review comment:
   @srowen 
   This test can also catch this case. But I think there is issue here, 
`"hadoop.caller.context.enabled"` always `false` for this test, so `if 
(CallerContext.callerContextSupported) ` always `false`. 
   In addition, `CallerContext` added after hadoop-2.8.0 for HDFS-9184,  so we 
need set hadoop-version >= 2.8.0 in pom.xml. And then this test will throw 
exception  if I am not change `build` to `build: Class[_]`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to