vanzin commented on issue #25709: [SPARK-29007][STREAMING][MLLIB] Enforce not leaking SparkContext in tests which creates new StreamingContext with new SparkContext URL: https://github.com/apache/spark/pull/25709#issuecomment-529025216 Well, it's hard to enforce that tests do the right thing (either call the static methods or extend from a common class that does the cleanup); but I'd prefer to follow existing patterns that creating yet another one. e.g. have a `LocalStreamingContext` trait like there is `LocalSparkContext` The `withStreamingContext` approach is also good, but to use that everywhere it would mean a lot of changes (mostly related to indentation, though).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
