rdblue commented on issue #25601: [SPARK-28856][SQL] Implement SHOW DATABASES for Data Source V2 Tables URL: https://github.com/apache/spark/pull/25601#issuecomment-529025421 This looks good to me other than the behavior when the catalog is not included in the `IN` clause. This uses `defaultCatalog`, but now the way we track catalogs has changed a bit: * The _current_ catalog should be used when no catalog is specified * The _default_ catalog is the catalog _current_ is initialized to * If the _default_ catalog is not set, then it is the built-in Spark session catalog, which I think we intend to call `spark_catalog` It looks like these rules are not universally followed, so I've opened SPARK-29014 to track this clean-up. I'm okay merging this and fixing the catalog defaults in a follow-up. FYI: @cloud-fan, @brkyvz.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
