maropu commented on a change in pull request #25708: [SPARK-28141][SQL] Support
special date values
URL: https://github.com/apache/spark/pull/25708#discussion_r321988241
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
##########
@@ -1056,28 +1056,35 @@ case class Cast(child: Expression, dataType: DataType,
timeZoneId: Option[String
private[this] def castToDateCode(
from: DataType,
- ctx: CodegenContext): CastFunction = from match {
- case StringType =>
- val intOpt = ctx.freshVariable("intOpt", classOf[Option[Integer]])
- (c, evPrim, evNull) => code"""
- scala.Option<Integer> $intOpt =
- org.apache.spark.sql.catalyst.util.DateTimeUtils.stringToDate($c);
- if ($intOpt.isDefined()) {
- $evPrim = ((Integer) $intOpt.get()).intValue();
- } else {
- $evNull = true;
- }
- """
- case TimestampType =>
+ ctx: CodegenContext): CastFunction = {
+ def getZoneId() = {
val zoneIdClass = classOf[ZoneId]
- val zid = JavaCode.global(
+ JavaCode.global(
ctx.addReferenceObj("zoneId", zoneId, zoneIdClass.getName),
zoneIdClass)
- (c, evPrim, evNull) =>
- code"""$evPrim =
-
org.apache.spark.sql.catalyst.util.DateTimeUtils.microsToEpochDays($c, $zid);"""
- case _ =>
- (c, evPrim, evNull) => code"$evNull = true;"
+ }
+ from match {
+ case StringType =>
+ val intOpt = ctx.freshVariable("intOpt", classOf[Option[Integer]])
+ val zid = getZoneId()
+ (c, evPrim, evNull) =>
+ code"""
+ scala.Option<Integer> $intOpt =
Review comment:
btw, (this is not related to this pr though), `scala.Option<Integer>` is ok
for java compilers/jvm? @rednaxelafx I remember that jdk compilers cannot
compile this statement:
https://github.com/apache/spark/pull/21770#discussion_r202562989 because it
seems the compilers erase the returned type from `scala.Option<Integer>` to
`scala.Option<Object>`. I'm not sure why janino accepts this though....
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
