maropu commented on a change in pull request #25708: [SPARK-28141][SQL] Support
special date values
URL: https://github.com/apache/spark/pull/25708#discussion_r321988501
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/csv/UnivocityParser.scala
##########
@@ -78,7 +78,10 @@ class UnivocityParser(
options.timestampFormat,
options.zoneId,
options.locale)
- private val dateFormatter = DateFormatter(options.dateFormat, options.locale)
+ private val dateFormatter = DateFormatter(
+ options.dateFormat,
+ options.zoneId,
+ options.locale)
Review comment:
Could you add simple tests for this code path?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
