maropu commented on a change in pull request #25716: [SPARK-29012][SQL] Support
special timestamp values
URL: https://github.com/apache/spark/pull/25716#discussion_r322507049
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/DateTimeUtilsSuite.scala
##########
@@ -564,4 +569,20 @@ class DateTimeUtilsSuite extends SparkFunSuite {
assert(DateTimeUtils.toMillis(-9223372036844776001L) ===
-9223372036844777L)
assert(DateTimeUtils.toMillis(-157700927876544L) === -157700927877L)
}
+
+ test("special timestamp values") {
+ DateTimeTestUtils.outstandingZoneIds.foreach { zoneId =>
+ val tolerance = TimeUnit.SECONDS.toMicros(30)
+
+ assert(toTimestamp("Epoch", zoneId).get === 0)
+ val now =
instantToMicros(LocalDateTime.now(zoneId).atZone(zoneId).toInstant)
+ toTimestamp("NOW", zoneId).get should be (now +- tolerance)
Review comment:
Can you check illegal cases, e.g., `now CET`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
