maropu commented on a change in pull request #25716: [SPARK-29012][SQL] Support
special timestamp values
URL: https://github.com/apache/spark/pull/25716#discussion_r322501344
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
##########
@@ -218,6 +220,8 @@ object DateTimeUtils {
var i = 0
var currentSegmentValue = 0
val bytes = s.trim.getBytes
+ val specialTimestamp = convertSpecialTimestamp(bytes, timeZoneId)
+ if (specialTimestamp.isDefined) return specialTimestamp
Review comment:
Can we avoid to use `return` here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
