HeartSaVioR commented on a change in pull request #23952: [SPARK-26929][SQL]fix
table owner use user instead of principal when create table through spark-sql
or beeline
URL: https://github.com/apache/spark/pull/23952#discussion_r322649305
##########
File path:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
##########
@@ -231,7 +231,7 @@ private[hive] class HiveClientImpl(
ugi.getShortUserName
} catch {
case e: Exception =>
- logWarning("Can not get login user.")
+ logError("Can not get login user.")
Review comment:
Same comment here: I'm not sure we really want to log error message here, as
I expect thrown exception will make query fail somewhere in caller side, and it
will log the exception correctly - stack trace in exception will tell us.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
