vanzin commented on a change in pull request #25725:
[SPARK-24663][STREAMING][TESTS] StreamingContextSuite: Wait until slow receiver
has been initialized, but with hard timeout
URL: https://github.com/apache/spark/pull/25725#discussion_r323011921
##########
File path:
streaming/src/test/scala/org/apache/spark/streaming/StreamingContextSuite.scala
##########
@@ -974,6 +977,7 @@ class SlowTestReceiver(totalRecords: Int,
recordsPerSecond: Int)
}
receivingThreadOption = Some(thread)
thread.start()
+ SlowTestReceiver.initialized = true
Review comment:
> as whether receiver is registered within time or not is the key
Ah ok. Was wondering if the thread that actually does stuff needed to run
for this to work, but if it's just the registration that matters, this is
enough.
But can't the flag be in the actual `SlowTestReceiver` instance (instead of
the object)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
