vanzin commented on a change in pull request #25725: 
[SPARK-24663][STREAMING][TESTS] StreamingContextSuite: Wait until slow receiver 
has been initialized, but with hard timeout
URL: https://github.com/apache/spark/pull/25725#discussion_r323444266
 
 

 ##########
 File path: 
streaming/src/test/scala/org/apache/spark/streaming/StreamingContextSuite.scala
 ##########
 @@ -974,6 +977,7 @@ class SlowTestReceiver(totalRecords: Int, 
recordsPerSecond: Int)
     }
     receivingThreadOption = Some(thread)
     thread.start()
+    SlowTestReceiver.initialized = true
 
 Review comment:
   > as the receiver will be executed in executor
   
   ok, that makes sense; I was under the impression it was a driver thing since 
an instance of it was passed to the context, instead of one created somehow in 
the executor.
   
   Anyway, what you have is fine.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to