cloud-fan commented on a change in pull request #25747: [SPARK-29039][SQL]
centralize the catalog and table lookup logic
URL: https://github.com/apache/spark/pull/25747#discussion_r323046755
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalog/v2/LookupCatalog.scala
##########
@@ -99,6 +99,21 @@ trait LookupCatalog extends Logging {
}
}
+ object CatalogAndRestNameParts {
+ def unapply(nameParts: Seq[String]): Some[(Option[CatalogPlugin],
Seq[String])] = {
+ if (nameParts.isEmpty) {
+ Some((defaultCatalog, Nil))
Review comment:
I'd like to make this PR a pure refactor and leave it to followups. For
example, we should add more tests when changing this to `currentCatalog`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
