cloud-fan commented on a change in pull request #25747: [SPARK-29039][SQL]
centralize the catalog and table lookup logic
URL: https://github.com/apache/spark/pull/25747#discussion_r323351528
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalog/v2/CatalogV2Implicits.scala
##########
@@ -92,6 +92,10 @@ object CatalogV2Implicits {
}
}
+ implicit class NamePartsHelper(nameParts: Seq[String]) {
+ def toIdentifier: Identifier = Identifier.of(nameParts.init.toArray,
nameParts.last)
Review comment:
`MultipartIdentifierHelper` takes a parameter called `namespace`. I'm a
little worried about semantic mismatch here so I created a new one. How about
we merge these two and call it `NamePartsHelper`? `nameParts` is very general.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
