MaxGekk commented on a change in pull request #25782: [SPARK-29074][SQL] Optimize `date_format` for foldable `fmt` URL: https://github.com/apache/spark/pull/25782#discussion_r324268365
########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala ########## @@ -589,22 +589,43 @@ case class DateFormatClass(left: Expression, right: Expression, timeZoneId: Opti override def inputTypes: Seq[AbstractDataType] = Seq(TimestampType, StringType) - override def withTimeZone(timeZoneId: String): TimeZoneAwareExpression = + var formatter: Option[TimestampFormatter] = None Review comment: In the case of `doGenCode`, what should I pass to `addReferenceObj()`? And call this lambda `formatter` per each value? Could you explain, please, why your code is better. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
