MaxGekk commented on a change in pull request #25782: [SPARK-29074][SQL] Optimize `date_format` for foldable `fmt` URL: https://github.com/apache/spark/pull/25782#discussion_r324413104
########## File path: sql/core/benchmarks/DateTimeBenchmark-results.txt ########## @@ -168,8 +168,8 @@ Java HotSpot(TM) 64-Bit Server VM 1.8.0_202-b08 on Mac OS X 10.14.3 Intel(R) Core(TM) i7-4850HQ CPU @ 2.30GHz format date: Best/Avg Time(ms) Rate(M/s) Per Row(ns) Relative ------------------------------------------------------------------------------------------------ -format date wholestage off 7180 / 7181 1.4 718.0 1.0X -format date wholestage on 7051 / 7194 1.4 705.1 1.0X +format date wholestage off 4787 / 4839 2.1 478.7 1.0X +format date wholestage on 4736 / 4802 2.1 473.6 1.0X Review comment: Next time we will update the file entirely since the format was changed slightly. For now I think it is fine to update the numbers only (The software (and hardware) on my laptop is the same so far). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
