zhengruifeng commented on a change in pull request #25776:
[SPARK-28985][PYTHON][ML] Add common classes
(JavaPredictor/JavaClassificationModel/JavaProbabilisticClassifier) in PYTHON
URL: https://github.com/apache/spark/pull/25776#discussion_r324535103
##########
File path: python/pyspark/ml/classification.py
##########
@@ -47,14 +47,41 @@
'OneVsRest', 'OneVsRestModel']
+class JavaClassifierParams(HasRawPredictionCol, JavaPredictorParams):
+ """
+ (Private) Java Classifier Params for classification tasks.
+ """
+ pass
+
+
+@inherit_doc
+class JavaClassifier(JavaPredictor, JavaClassifierParams):
+ """
+ Java Classifier for classification tasks.
+ Classes are indexed {0, 1, ..., numClasses - 1}.
+ """
+
+ def setRawPredictionCol(self, value):
Review comment:
`HasRawPredictionCol` in `JavaClassifierParams` already support this method,
right?
My previous PR https://github.com/apache/spark/pull/25662/files added this
method because the setters generated by code_gen were removed in it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
