zhengruifeng commented on a change in pull request #25776:
[SPARK-28985][PYTHON][ML] Add common classes
(JavaPredictor/JavaClassificationModel/JavaProbabilisticClassifier) in PYTHON
URL: https://github.com/apache/spark/pull/25776#discussion_r324537377
##########
File path: python/pyspark/ml/tests/test_param.py
##########
@@ -343,7 +343,8 @@ def test_java_params(self):
for module in modules:
for name, cls in inspect.getmembers(module, inspect.isclass):
if not name.endswith('Model') and not name.endswith('Params') \
- and issubclass(cls, JavaParams) and not
inspect.isabstract(cls):
+ and issubclass(cls, JavaParams) and not
inspect.isabstract(cls) \
+ and not name.startswith('Java'):
Review comment:
What will happen if we do not change this place?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
