srowen commented on a change in pull request #25776: [SPARK-28985][PYTHON][ML]
Add common classes
(JavaPredictor/JavaClassificationModel/JavaProbabilisticClassifier) in PYTHON
URL: https://github.com/apache/spark/pull/25776#discussion_r324768221
##########
File path: python/pyspark/ml/classification.py
##########
@@ -47,14 +47,41 @@
'OneVsRest', 'OneVsRestModel']
+class JavaClassifierParams(HasRawPredictionCol, JavaPredictorParams):
+ """
+ (Private) Java Classifier Params for classification tasks.
+ """
+ pass
+
+
+@inherit_doc
+class JavaClassifier(JavaPredictor, JavaClassifierParams):
+ """
+ Java Classifier for classification tasks.
+ Classes are indexed {0, 1, ..., numClasses - 1}.
+ """
+
+ def setRawPredictionCol(self, value):
Review comment:
As a broad comment, I'd say retain `@Since` information if it already
existed. Did this exist already? if it was added in 3.0 we can mark it as such.
If it replaces several definitions in subclasses that have inconsistent "since"
versions, hm, I think we should label it as "since" the latest version of any
of them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
