srowen commented on a change in pull request #25776: [SPARK-28985][PYTHON][ML]
Add common classes
(JavaPredictor/JavaClassificationModel/JavaProbabilisticClassifier) in PYTHON
URL: https://github.com/apache/spark/pull/25776#discussion_r324766793
##########
File path: python/pyspark/ml/classification.py
##########
@@ -64,10 +91,56 @@ def numClasses(self):
return self._call_java("numClasses")
+class JavaProbabilisticClassifierParams(HasProbabilityCol, HasThresholds,
JavaClassifierParams):
+ """
+ (Private) Java Probabilistic Classifier Params for classification tasks.
+ """
+ pass
Review comment:
I'm OK with adding this class for parity, though indeed they are no-ops in
Python. In Scala they only contain some internal logic. I'd be OK removing
these too, but it's OK to have if it's not costing much of anything.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
