cloud-fan commented on a change in pull request #25747: [SPARK-29039][SQL]
centralize the catalog and table lookup logic
URL: https://github.com/apache/spark/pull/25747#discussion_r325484422
##########
File path:
sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/TableChange.java
##########
@@ -210,6 +213,20 @@ public String property() {
public String value() {
return value;
}
+
+ @Override
+ public boolean equals(Object o) {
Review comment:
these `equal/hashCode` are useful in general and we need them in tests.
These are generated by IDE, we can also implement these classes in Scala case
class to get `equal/hashCode` for free.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
